Closed eskultety closed 2 weeks ago
Since v1:
corepack
tends to drop support for old engines leading to various crashes (either in corepack or its shims, e.g. Yarn), IOW if we copy the corepack installation from a language base image we need to make sure we also copy the NodeJS installation it is being shipped with in the official image to ensure smooth compatibility (see commit 1)Rebased on top of main.
The motivation behind this PR stems from the following:
js-deps
directory which was only ever meant to be a build aid to make sure that: a) we're working with new enough Node that ships with corepack b) we're enabling and hence installing the correct Yarn version (v3) in the final image (Note: Yarn installation needs a namespace not to create artifacts on the global level for which we used thejs-deps
directory)Depends on: https://github.com/containerbuildsystem/cachi2/pull/528Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test
(as is the standard for Pipelines as Code)