Closed chmeliik closed 1 month ago
This should be everything that's needed for cachi2 to support custom PyPI servers, including auth.
Auth is done via .netrc, same as pip: https://pip.pypa.io/en/stable/topics/authentication/#netrc-support. Pip also supports keyring auth but the docs make it sound rather strange. Doesn't seem worth supporting.
Let me know if you would like an ADR for any of this :saluting_face:
TODO: make the integration test run in CI, ideally without copy-pasting most of the Makefile target
Wow, this did indeed end up being quite straightforward. LGTM so far :+1:
I've made the CI work with the new int. test, should be ready for review
One more small improvement: used contextlib.ExitStack to make absolutely sure the process get .terminate()
-ed before python starts waiting for it to clean it up
Just a rebase, will address comments in next force-push
TLDR:
--index-url
in requirements.txt is no longer ignored.netrc
Run new test with:
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test
(as is the standard for Pipelines as Code)