search

containerbuildsystem / cachi2

Cachi2 is a CLI tool that pre-fetches your project's dependencies to aid in making your build process network-isolated.
GNU General Public License v3.0
8 stars 26 forks source link

Asynchronous binary artifact fetching doesn't honor the request timeout config option #571

Closed eskultety closed 3 months ago

eskultety commented 3 months ago

We're solely relying on the default aiohttp.ClientTimeout which is 5 minutes [1] which may not be enough for large binary files (e.g. 1GB) under certain circumstances:

ERROR Unsuccessful download: https://dl.fedoraproject.org/pub/fedora/linux/releases/40/Everything/source/tree/Packages/g/google-noto-fonts-20240301-2.fc40.src.rpm
ERROR FetchError: exception_name: TimeoutError, details: 
[prefetch-dependencies] Error: FetchError: exception_name: TimeoutError, details: 
[prefetch-dependencies]   The error might be intermittent, please try again.
[prefetch-dependencies]   If the issue seems to be on the Cachi2 side, please contact the maintainers.

[1] https://docs.aiohttp.org/en/stable/client_reference.html#aiohttp.ClientSession