Closed eskultety closed 3 months ago
Note that commits 5 and 6 are going to be squashed together before merging, I split them only for review purposes to make the regex changes easier to track.
Since v1:
go.mod
file. I verified that this PR fixes the problem reported in the description based on the original buildah submodule ref used here: https://github.com/konflux-ci/buildah-container/commit/588f5baf3d2e4d8e4ffa02d7ed604c6543874dffNote that commits 5 and 6 are going to be squashed together before merging, I split them only for review purposes to make the regex changes easier to track.
As advertised, I squashed the two before merging.
We currently don't allow prerelease version identifiers (e.g. beta/rc, etc.) and commentaries on the version string line (e.g.
go 1.21.0//comment
.This PR mainly fixes a nasty bug where we fell back to picking an older Go version because of ^this which resulted in a very strange error trying to build buildah from git:
even though buildah uses 1.21 already. This PR also updates some unit tests and adds debug logs to keep better track of dealing with version string parsing.
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test
(as is the standard for Pipelines as Code)