containerbuildsystem / cachi2

Cachi2 is a CLI tool that pre-fetches your project's dependencies to aid in making your build process network-isolated.
GNU General Public License v3.0
7 stars 25 forks source link

[ISV-5094] cachi2 PNC package manager design #590

Closed kosciCZ closed 2 days ago

kosciCZ commented 1 month ago

Maintainers will complete the following section

Note: if the contribution is external (not from an organization member), the CI pipeline will not run automatically. After verifying that the CI is safe to run:

kosciCZ commented 1 month ago

@brunoapimentel @chmeliik @eskultety Here's the initial draft of the PNC package manager from KONFLUX-3403, that you've asked for in our last meeting. Please review it and I'll be happy to work in your feedback. Thanks!

cc @allda

brunoapimentel commented 1 month ago

Overall comment: you don't need to follow exactly the structure of the other designs. I think we are mainly separating the design into two distinct parts:

(we are still considering an "official" format for designs, so this might change a little, but don't worry about it now)

brunoapimentel commented 1 month ago

A suggestion that could aid the design is to implement a PoC. Note that this is not required for the design to be approved, so please only do it if you feel like it would be helpful. I do think that it usually helps to clarify a lot of the design details, and even antecipate some of the issues that can happen.

Here's the PoC created for the Ruby design, and the corresponding test repo we are using alongside with it.

kosciCZ commented 4 weeks ago

@brunoapimentel thanks for the suggestion. In my opinion, implementing a PoC is an overkill in this case, as the PoC is basically already the work we want to do, so we might as well do it properly the first time around. However, using a test repo is a good idea, even if it should be manual testing during the development (we can figure out the automated integration testing in that thread above)

kosciCZ commented 2 days ago

Closing, as we decided to take a different approach. Will open a new PR for the new design to be reviewed.