containerbuildsystem / cachi2

Cachi2 is a CLI tool that pre-fetches your project's dependencies to aid in making your build process network-isolated.

GNU General Public License v3.0

7 stars 25 forks source link

cachi2 coverage #592

Closed slimreaper35 closed 2 weeks ago

slimreaper35 commented 1 month ago

Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] Docs updated (if applicable)
[ ] Docs links in the code are still valid (if docs were updated)

Note: if the contribution is external (not from an organization member), the CI pipeline will not run automatically. After verifying that the CI is safe to run:

approve GitHub Actions workflows by clicking a button
approve the Red Hat Trusted App Pipeline container build by commenting /ok-to-test (as is the standard for Pipelines as Code)

ben-alkov commented 1 month ago

LGTM so far. Nice work :taco:

slimreaper35 commented 1 month ago

Looks reasonable, @slimreaper35 do you have a preview of the intended settings you have in mind showcased somewhere in practice?

Yes, I was mostly playing around with those layout options, but didn't notice big differences. https://github.com/slimreaper35/cachi2/pulls?q=is%3Apr+is%3Aclosed

codecov[bot] commented 2 weeks ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

slimreaper35 commented 2 weeks ago

New push:

Drop unrelated coverage commit
I replaced uses: codecov/codecov-action@v4.0.1 for major version uses: codecov/codecov-action@v4 (which works as expected finally)
Coverage will be published only for python3.12

TODO:

Still to figure out options in codecov.yaml

MartinBasti commented 2 weeks ago

/retest