containerbuildsystem / cachi2

Cachi2 is a CLI tool that pre-fetches your project's dependencies to aid in making your build process network-isolated.

GNU General Public License v3.0

7 stars 25 forks source link

misc: .gitignore: Add Vim-related files to .gitignore #596

Closed a-ovchinnikov closed 1 month ago

a-ovchinnikov commented 1 month ago

Temporary files and ctags output.

Maintainers will complete the following section

[x] Commit messages are descriptive enough
[-] Code coverage from testing does not decrease and new code is covered
[-] Docs updated (if applicable)
[-] Docs links in the code are still valid (if docs were updated)

Note: if the contribution is external (not from an organization member), the CI pipeline will not run automatically. After verifying that the CI is safe to run:

approve GitHub Actions workflows by clicking a button
approve the Red Hat Trusted App Pipeline container build by commenting /ok-to-test (as is the standard for Pipelines as Code)

eskultety commented 1 month ago

I know it's too late, but this should have never gone to main. The choice of editor is personal (so is usage of ctags) and having just a couple of vim generated swap files in the repo gitignore means that other people will be tempted to add their own bunch of IDE-generated cruft. We've gone through this in the past project and people kept adding many unrelated patterns. This personalized repo-irrelevant ignore patterns should go to one's global .gitignore (e.g. under home). @a-ovchinnikov would you please post a revert for this change?

eskultety commented 1 month ago

Looks like I hit send a little too soon. I responded before having actually looked at our .gitignore first. Looks like our current ignore file was copy-pasted from cachito and it already contains stuff that is irrelevant to the project kinda setting the precedent. @a-ovchinnikov up to you whether you want to deal with the cleanup or leave it as is for now, if not I'll strip it down at some point.

a-ovchinnikov commented 1 month ago

@eskultety I followed existing practice for the project. Having a separate .gitignore is also fine, but I would suggest at the very least documenting this in either .gitignore, or README.md or both. I'll keep it as is for now, once a standard approach is agreed upon I will follow it.

eskultety commented 1 month ago

Yeah, I added #596 in the meantime and this will ultimately become part of our contributing guidelines.