Install missing dependency in testing script

containerbuildsystem / koji-containerbuild

Container build support for Koji buildsystem

GNU Lesser General Public License v2.1

29 stars 31 forks source link

Install missing dependency in testing script #128

Closed chmeliik closed 5 years ago

chmeliik commented 5 years ago

For fedora-based tests, dockerfile-parse was only installed as a side effect of installing osbs-client. With recent changes to the osbs-client specfile, tests for python2 on fedora have started failing. Install dockerfile-parse explicitly to prevent this.

Signed-off-by: Adam Cmiel acmiel@redhat.com

chmeliik commented 5 years ago

@athos-ribeiro Is there any easy way to install the package directly from the spec file? Or at least install all the Requires dependencies? That way we would not have to specify runtime dependencies as BuildRequires instead of Requires and the tests could verify that the spec file defines all the required dependencies.

Either way, good point about installing dockerfile-parse from github, updated PR.

MartinBasti commented 5 years ago

@athos-ribeiro I don't think we want to test Builddeps here. Distro-specific tests should be separated IMHO.

MartinBasti commented 5 years ago

NO release notes needed, change in testing