source container build - Githubissues

containerbuildsystem / koji-containerbuild

Container build support for Koji buildsystem

GNU Lesser General Public License v2.1

29 stars 32 forks source link

source container build #142

Closed rcerven closed 4 years ago

rcerven commented 4 years ago

OSBS-8041

Signed-off-by: Robert Cerven rcerven@redhat.com

Maintainers will complete the following section:

[ ] Commit messages are descriptive enough
[x] "Signed-off-by:" line is present in each commit
[x] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[ ] Pull request includes link to an osbs-docs PR for user documentation updates

lgtm-com[bot] commented 4 years ago

This pull request fixes 1 alert when merging 4a7e4cff9446f4231111fa74f7572b45878ce72e into 5ded5a816258f08f44616ece1f91a50d4ca74022 - view on LGTM.com

fixed alerts:

1 for Unused local variable

athos-ribeiro commented 4 years ago

Looks good!

lgtm-com[bot] commented 4 years ago

This pull request fixes 1 alert when merging 32451a56c2cd340e970365ce624915baa577e1c7 into 5ded5a816258f08f44616ece1f91a50d4ca74022 - view on LGTM.com

fixed alerts:

1 for Unused local variable

lgtm-com[bot] commented 4 years ago

This pull request fixes 1 alert when merging 9139dc4e1d5b8be815b23bfa89846ada5d66d84c into 5ded5a816258f08f44616ece1f91a50d4ca74022 - view on LGTM.com

fixed alerts:

1 for Unused local variable

lgtm-com[bot] commented 4 years ago

This pull request fixes 1 alert when merging 3abebc9b2a59079adb43db84a2c9710c149a1eb1 into 5ded5a816258f08f44616ece1f91a50d4ca74022 - view on LGTM.com

fixed alerts:

1 for Unused local variable

MartinBasti commented 4 years ago

osbs-client must be updated before merging

osbs.exceptions.OsbsException: create_source_container_build() got an unexpected keyword argument \'component\'\n'

rcerven commented 4 years ago

osbs-client must be updated before merging

osbs.exceptions.OsbsException: create_source_container_build() got an unexpected keyword argument \'component\'\n'

yes osbs-client has to be updated, but I don't think we have to block merging on that, as that happens only when we will actually try to run brew source-container-build

rcerven commented 4 years ago

osbs-client PR for handling component https://github.com/containerbuildsystem/osbs-client/pull/904

twaugh commented 4 years ago

I have just one question about task params, currently params shows what was called by users via koji (expected). But for source containers would be useful to always have koji_build_id (even id user used only koji_build_nvr param) present for consistency and easier automation. Is that even possible or feasible? (This should not block this PR from merging, should be addressed separately (if))

I think that should be taken from the metadata of the resulting build (sourcefor*).

MartinBasti commented 4 years ago

I have just one question about task params, currently params shows what was called by users via koji (expected). But for source containers would be useful to always have koji_build_id (even id user used only koji_build_nvr param) present for consistency and easier automation. Is that even possible or feasible? (This should not block this PR from merging, should be addressed separately (if))

I think that should be taken from the metadata of the resulting build (sourcefor*).

But task exists even before build is finished (or build will fail), so it should be set by koij-c client part.

rcerven commented 4 years ago

rn updated: - new source-container-build option for building source containers