use orchestrator.log name for log in task for source container

containerbuildsystem / koji-containerbuild

Container build support for Koji buildsystem

GNU Lesser General Public License v2.1

29 stars 32 forks source link

use orchestrator.log name for log in task for source container #152

Closed rcerven closed 4 years ago

rcerven commented 4 years ago

OSBS-8378

Signed-off-by: Robert Cerven rcerven@redhat.com

Maintainers will complete the following section:

[x] Commit messages are descriptive enough
[x] "Signed-off-by:" line is present in each commit
[ ] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[ ] Pull request includes link to an osbs-docs PR for user documentation updates

MartinBasti commented 4 years ago

How regular builds determine name orchestrator.log?

twaugh commented 4 years ago

The usual path is through _write_demultiplexed_logs, where the log file to use is decide on based on fields in the log lines.

athos-ribeiro commented 4 years ago

It would be nicer to have this responsibility in the BuildSourceContainerTask class instead of adding an attribute for that, if feasible. Not sure how the best way to approach this would look like though. Maybe the log filename could be passed in a class attr or _write_combied_log could be refactored

rcerven commented 4 years ago

changed

rcerven commented 4 years ago

rn updated: use orchestrator.log name for log in task for source container