containerbuildsystem / koji-containerbuild

Container build support for Koji buildsystem

GNU Lesser General Public License v2.1

29 stars 32 forks source link

containerbuild: check availability of services before starting #185

Closed mlangsdorf closed 2 years ago

mlangsdorf commented 4 years ago

add a new function, check_servers_up, that takes a map of urls to service names/flags and uses the cachet API to confirm that all the services are available before attempting to submit a build to the build system.

Signed-off-by: Mark Langsdorf mlangsdo@redhat.com

Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Pull request has a link to an osbs-docs PR for user documentation updates

TODO

[ ] Parse flags from configuration JSON
[ ] Test cases for failing services causing the build to pause I'd like a quick review that this is the right approach

packit-as-a-service[bot] commented 4 years ago

Congratulations! One of the builds has completed. :champagne:

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/containerbuildsystem-koji-containerbuild-185
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 8d6e7f3658e4a5beb91fc002708dad07f4f43e7f into 893a5019be8f68592749efcdb6eb53ccd62b1c35 - view on LGTM.com

new alerts:

1 for Syntax error

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging fd31085ce7ecdd076cef56e24a71d99daba91497 into 893a5019be8f68592749efcdb6eb53ccd62b1c35 - view on LGTM.com

new alerts:

1 for Syntax error

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 244aee836614311ae9d638cae2dafc07ac252cd6 into 893a5019be8f68592749efcdb6eb53ccd62b1c35 - view on LGTM.com

new alerts:

1 for Syntax error

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 1bb86387ecffc3b659b077984250c5b31cfd675f into 893a5019be8f68592749efcdb6eb53ccd62b1c35 - view on LGTM.com

new alerts:

1 for Syntax error

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 9406ea4b0fa8e40f36cb4f364bdc6104804e2883 into 893a5019be8f68592749efcdb6eb53ccd62b1c35 - view on LGTM.com

new alerts:

1 for Unused local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging ae90c5afca4ba376fb4ea966c2a89cba2af5132b into 893a5019be8f68592749efcdb6eb53ccd62b1c35 - view on LGTM.com

new alerts:

1 for Unused local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 9db00be0627134199611e253491e0795bac3e161 into 893a5019be8f68592749efcdb6eb53ccd62b1c35 - view on LGTM.com

new alerts:

1 for Unused local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 8d1475f351fc36482ddd2e4fff175fb6a78951f2 into 893a5019be8f68592749efcdb6eb53ccd62b1c35 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 8c9b999f1229cbfecd6bf7d40af5905937084604 into 893a5019be8f68592749efcdb6eb53ccd62b1c35 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 59b1d34853895a09cbd2d831f6c36c3d4ce11e6e into 893a5019be8f68592749efcdb6eb53ccd62b1c35 - view on LGTM.com

new alerts:

1 for Unused import