builder: document space delimiter for arch_override

containerbuildsystem / koji-containerbuild

Container build support for Koji buildsystem

GNU Lesser General Public License v2.1

29 stars 31 forks source link

builder: document space delimiter for arch_override #190

Closed ktdreyer closed 3 years ago

ktdreyer commented 4 years ago

When a client calls the buildContainer RPC with the arch_override option, the client must separate each architecture name with at least one whitespace character, because we call split() on this string.

This requirement is slightly different than the container-build CLI plugin or other Koji APIs, because in the container-build CLI, we call Koji's parse_arches() method, which handles commas or spaces.

Explain this requirement in the JSON schema.

Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
n/a JSON/YAML configuration changes are updated in the relevant schema
n/a Pull request has a link to an osbs-docs PR for user documentation updates

ben-alkov commented 4 years ago

/packit build

packit-as-a-service[bot] commented 4 years ago

Congratulations! One of the builds has completed. :champagne:

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/containerbuildsystem-koji-containerbuild-190
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

MartinBasti commented 4 years ago

    from pyrsistent import pmap
build/bdist.linux-x86_64/egg/pyrsistent/__init__.py:3: in <module>
    ???
E     File "/usr/lib/python2.7/site-packages/pyrsistent-0.17.3-py2.7-linux-x86_64.egg/pyrsistent/_pmap.py", line 98
E       ) from e
E            ^
E   SyntaxError: invalid syntax

We have to freeze pyrsistent to support py2 :|

MartinBasti commented 4 years ago

    from pyrsistent import pmap
build/bdist.linux-x86_64/egg/pyrsistent/__init__.py:3: in <module>
    ???
E     File "/usr/lib/python2.7/site-packages/pyrsistent-0.17.3-py2.7-linux-x86_64.egg/pyrsistent/_pmap.py", line 98
E       ) from e
E            ^
E   SyntaxError: invalid syntax

We have to freeze pyrsistent to support py2 :|

or we have to update pip to properly resolve supported deps

MartinBasti commented 3 years ago

No release notes needed, minor doc fix