containerbuildsystem / koji-containerbuild

Container build support for Koji buildsystem

GNU Lesser General Public License v2.1

29 stars 31 forks source link

Trap OsbsValidationException, print it, and raise it as ContainerError #192

Closed ben-alkov closed 3 years ago

ben-alkov commented 3 years ago

CLOUDBLD-2729

Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[x] Pull request has a link to an osbs-docs PR for user documentation updates

packit-as-a-service[bot] commented 3 years ago

Congratulations! One of the builds has completed. :champagne:

You can install the built RPMs by following these steps:

sudo yum install -y dnf-plugins-core on RHEL 8
sudo dnf install -y dnf-plugins-core on Fedora
dnf copr enable packit/containerbuildsystem-koji-containerbuild-192
And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

ben-alkov commented 3 years ago

Tested in osbs-box:

[fedora@balkov-osbs-box ~]$ oc rsh dc/koji-client koji container-build osbs-test-1.0-rhel-7-containers-candidate 'git://foo.redhat.com/containers/osbs-test-sandwich#3bcf13d' --git-branch balkov-test
Created task: 4
Task info: https://koji-hub/koji/taskinfo?taskID=4
Watching tasks (this may be safely interrupted)...
4 buildContainer (noarch): free
4 buildContainer (noarch): free -> FAILED: Fault: <Fault 2001: "OSBS validation exception: version label '1.0.reject-hyphen.in.version.label' contains not allowed chars : '['-']'">
  0 free  0 open  0 done  1 failed

MartinBasti commented 3 years ago

I think we should catch OsbsException it will cover all OSBS exceptions

ben-alkov commented 3 years ago

I think we should catch OsbsException it will cover all OSBS exceptions

ACK