containerbuildsystem / koji-containerbuild

Container build support for Koji buildsystem
GNU Lesser General Public License v2.1
29 stars 32 forks source link

Use new osbs methods with tekton #218

Closed rcerven closed 2 years ago

rcerven commented 2 years ago

Signed-off-by: Robert Cerven rcerven@redhat.com

Maintainers will complete the following section

rcerven commented 2 years ago

related osbs-client https://github.com/containerbuildsystem/osbs-client/pull/1051

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging 1cd2f24e02c907ac46cb4a9aa428fcf1e6fe5385 into 536aac1a6f8c96fc86b836860f6e3c7ce24a6be0 - view on LGTM.com

fixed alerts:

chmeliik commented 2 years ago

Going through the checklist: could the commit message be more descriptive, or could we have more than 1 commit? The new tekton methods are not the only change, this also changes log handling and removes params from the public API

Because this touches autorebuilds, I'm also going to point out that they are still mentioned in the docs https://osbs.readthedocs.io/en/master/search.html?q=autorebuild&check_keywords=yes&area=default

rcerven commented 2 years ago

https://github.com/containerbuildsystem/osbs-docs/pull/205

rcerven commented 2 years ago

added more info in the commit

rcerven commented 2 years ago

rn updated