containerbuildsystem / koji-containerbuild

Container build support for Koji buildsystem

GNU Lesser General Public License v2.1

29 stars 32 forks source link

rename build log to osbs-build.log #228

Closed rcerven closed 2 years ago

rcerven commented 2 years ago

CLOUDBLD-8281

Signed-off-by: Robert Cerven rcerven@redhat.com

Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Pull request has a link to an osbs-docs PR for user documentation updates

mkosiarc commented 2 years ago

@rcerven Code looks good to me, but I have no idea why the name was changed or why we strip those new lines - the jira itself does not provide any explanation. Could you please update the commit messages explaining the change?

rcerven commented 2 years ago

@rcerven Code looks good to me, but I have no idea why the name was changed or why we strip those new lines - the jira itself does not provide any explanation. Could you please update the commit messages explaining the change?

added explanations in the commits

rcerven commented 2 years ago

rn not updated, change for unreleased changes