containerbuildsystem / koji-containerbuild

Container build support for Koji buildsystem

GNU Lesser General Public License v2.1

29 stars 32 forks source link

Process Tekton results instead of labels and annotations #231

Closed chmeliik closed 2 years ago

chmeliik commented 2 years ago

More details in individual commits

Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
[n/a] JSON/YAML configuration changes are updated in the relevant schema
[x] Pull request has a link to an osbs-docs PR for user documentation updates

chmeliik commented 2 years ago

PTAL, depends on containerbuildsystem/osbs-client#1076 but otherwise should be done-ish

This will need a docs update, will work on that soon

We will also want to follow up on removing the task_annotations_whitelist from atomic-reactor config, I'll either do it now or file a separate story for it

chmeliik commented 2 years ago

docs pr: https://github.com/containerbuildsystem/osbs-docs/pull/207

chmeliik commented 2 years ago

Packit is stuck on Fedora 36, merging anyway

chmeliik commented 2 years ago

Release notes:

Task results (repositories, koji_build_id) are now taken from Tekton results rather than labels and annotations
The build_annotations.json file in task output is generated from Tekton results rather than annotations
- It is no longer possible to configure the included annotations via the koji_task_annotations_whitelist