containerbuildsystem / koji-containerbuild

Container build support for Koji buildsystem
GNU Lesser General Public License v2.1
29 stars 32 forks source link

change default channel for buildSourceContainer to container-source #233

Closed rcerven closed 2 years ago

rcerven commented 2 years ago

Signed-off-by: Robert Cerven rcerven@redhat.com

Maintainers will complete the following section

chmeliik commented 2 years ago

Could somebody remind me why we need it?

Is it just to make sure we have the correct default, or does this fix some problems for integration tests or something?

rcerven commented 2 years ago

Could somebody remind me why we need it?

Is it just to make sure we have the correct default, or does this fix some problems for integration tests or something?

if we have default channel container, we need koji rule, but when there is koji rule, we can't use koji channel override

rcerven commented 2 years ago

Noticed that the docstring still says the default is "container"

Other than that LGTM

removed that 'default channel' from the comment as it duplicates implicit param ...

rcerven commented 2 years ago

rn updated