Closed parkerduckworth closed 9 months ago
In this version of ebpf, this extract-vmlinux file was added to the repository, which contains a GPL-2.0-only clause, which is incompatible with our license compliance guidelines.
Just to confirm, this file is just test data and not consumed by containerd, right? If so, "license conflict" doesn't seem to be correct words.
Sorry, just saw this pull request. I just merged this one https://github.com/containerd/cgroups/pull/315
I think there is no license issue.
Background
Hello containerd team 👋
We are working on adding more resource guardrails into the Weaviate vector database, and in doing so need to read cgroup limits. Your library here is amazing, and exactly what we need. Unfortunately, we are having license compliance issues by depending on it.
Cgroups currently depends directly on ebpf v0.9.1. In this version of ebpf, this extract-vmlinux file was added to the repository, which contains a
GPL-2.0-only
clause, which is incompatible with our license compliance guidelines.The good news is, that with v0.11.0, ebpf removed this file, for similar license conflicts (commit message for the change in their repo):
Changes
This PR bumps the ebpf version from v0.9.1 -> v0.11.0 to avoid license compliance issues based on a single file in ebpf, which was introduced in v0.9.1, and removed in v0.11.0.
Tests
The patch has been verified by running tests locally on an Ubuntu (20.04 LTS) VM:
Contribution Guidelines
I have read your guidelines, and I have done my best to comply with them. If there is still something which needs to be done, I'm happy to do so.