search

containerd / containerd

An open and reliable container runtime
https://containerd.io
Apache License 2.0
17.57k stars 3.47k forks source link

Incorrect logging from port-forward error #8490

Open cyclinder opened 1 year ago

cyclinder commented 1 year ago

What is the problem you're trying to solve

The original report came from https://github.com/kubernetes/kubernetes/issues/117076, It seems we don't set the UID and we set "Pod Name" to the sandbox ID. https://github.com/containerd/containerd/blob/57c526b0002c40137811579988b3f85c8b39dd92/pkg/cri/streaming/server.go#L374

I opened a PR: https://github.com/kubernetes/kubernetes/pull/117128 to fix it, k/k's reviewers say it requiring coordinating changes with container runtimes.

If someone can give me advice I would be appreciated it. Thanks.

Describe the solution you'd like

Please refer to https://github.com/kubernetes/kubernetes/pull/117128/files

Additional context

No response

lengrongfu commented 1 year ago

/assign

lengrongfu commented 1 year ago

containerd depends on the cri-api module, so you need to modify this module first. If the cri-api accepts a PR for the fix, I'd be happy to revise the issue in this project.

https://github.com/kubernetes/cri-api/blob/73b5f97c779e8876c9be09ef28e6097d16ddc17b/pkg/apis/runtime/v1/api.proto#L1360