search

containerd / continuity

A transport-agnostic, filesystem metadata manifest system
https://containerd.io
Apache License 2.0
141 stars 67 forks source link

Move containerd fs package in tree #101

Closed cpuguy83 closed 6 years ago

cpuguy83 commented 6 years ago

This allows the fs package to be versioned separately from containerd and makes for a nice interface for filesystem interactions in continuity.

cpuguy83 commented 6 years ago

I have not yet setup the Makefile for root tests ala containerd.

stevvooe commented 6 years ago

LGTM on first pass.

justincormack commented 6 years ago

Ah good, I need to find some time to work on this now...

cpuguy83 commented 6 years ago

For some reason we need sudo to run the fs tests. copy_file_range is getting EPERM otherwise.... could be related to a seccomp policy or something in the travis container config?

cpuguy83 commented 6 years ago

Ok, this is green.

AkihiroSuda commented 6 years ago

LGTM, I think we should reorganize README to cover non-proto packages like this

justincormack commented 6 years ago

Sudo doesnt affest seccomp policy so no...

On 25 Jan 2018 00:09, "Brian Goff" notifications@github.com wrote:

For some reason we need sudo to run the fs tests. copy_file_range is getting EPERM otherwise.... could be related to a seccomp policy or something in the travis container config?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/containerd/continuity/pull/101#issuecomment-360317104, or mute the thread https://github.com/notifications/unsubscribe-auth/AAdcPCzNiyUpmB3pSjBzGhSaiPtC9qnoks5tN8Y-gaJpZM4RqmbC .

cpuguy83 commented 6 years ago

@justincormack Well, when sudo is used on travis you get a full VM rather than a container.

justincormack commented 6 years ago

Ah. Well almost certainly then they are running a seccomp policy/docker version that is older than their kernel, so doesnt know about copy_file_range and blocks it, while the kernel does support it..

dmcgowan commented 6 years ago

Can you drop the github.com/containerd/containerd files now that they are no longer needed. I see you already removed the errdefs requirement and removed from the vendor file.

cpuguy83 commented 6 years ago

Good catch, done.