containerd / continuity

A transport-agnostic, filesystem metadata manifest system
https://containerd.io
Apache License 2.0
141 stars 67 forks source link

Add time type conversion for 32 bit linix platforms #105

Closed tkporter closed 6 years ago

tkporter commented 6 years ago

Ensures the time.Unix function is given int64 arguments. I'm running 32 bit Debian 9.1-- this fixes the following error when building containerd after this PR added the continuity fs package to containerd:

# github.com/containerd/containerd/vendor/github.com/containerd/continuity/fs
../../containerd/containerd/vendor/github.com/containerd/continuity/fs/stat_linux.go:25:26: cannot use st.Atim.Sec (type int32) as type int64 in argument to time.Unix
../../containerd/containerd/vendor/github.com/containerd/continuity/fs/stat_linux.go:25:39: cannot use st.Atim.Nsec (type int32) as type int64 in argument to time.Unix

I recently had a PR merged for pretty much the same fix in the containerd repo

stevvooe commented 6 years ago

LGTM