sysx: use xattr functions from x/sys/unix

containerd / continuity

A transport-agnostic, filesystem metadata manifest system

https://containerd.io

Apache License 2.0

141 stars 67 forks source link

sysx: use xattr functions from x/sys/unix #108

Closed tklauser closed 6 years ago

tklauser commented 6 years ago

Use the xattr functions from package golang.org/x/sys/unix instead of syscall. Also use its L*xattr functions instead of locally duplicating them.

Signed-off-by: Tobias Klauser tklauser@distanz.ch

dmcgowan commented 6 years ago

Which functions are still missing from golang.org/x/sys/unix? The goal of sysx is to eventually go away and be replaced by golang.org/x/sys/unix.

tklauser commented 6 years ago

AFAICS, the *xattr functions for darwin are missing from x/sys/unix. I'll send a CL for those and update this PR afterwards. Plus, there are a few wrappers in sysx, e.g. getxattrAll or listxattrAll. I'm not sure whether we should add these to x/sys/unix though.

dmcgowan commented 6 years ago

LGTM