search

containerd / continuity

A transport-agnostic, filesystem metadata manifest system
https://containerd.io
Apache License 2.0
139 stars 67 forks source link

Fix directory comparison in changes #140

Closed dmcgowan closed 5 years ago

dmcgowan commented 5 years ago

Currently string comparison is used to detect changes. The comparisons are already done ordered, however since - will compare before /, a directory deletion which also has a directory ending with - can cause the wrong change output. The comparisons must be done considering directory separators as the lowest sorting value.

Related to https://github.com/moby/buildkit/issues/960

AkihiroSuda commented 5 years ago

1 maintainer LGTM and 1 reviewer LGTM. Merging.