search

containerd / continuity

A transport-agnostic, filesystem metadata manifest system
https://containerd.io
Apache License 2.0
138 stars 66 forks source link

Fix usage calculation to account for sparse files #163

Closed dmcgowan closed 3 years ago

dmcgowan commented 3 years ago

The current usage calculation does not correctly account for usage within spares files. To correctly account for the usage, the number of blocks must be used rather than the reported file size.

thaJeztah commented 3 years ago

@chris-crone you love storage; perhaps you want to review as well?

crosbymichael commented 3 years ago

LGTM

justincormack commented 3 years ago

I mean, no value is really correct with COW filesystems, tail packing, etc. What is the issue that this is trying to fix (I was told there was one).

dmcgowan commented 3 years ago

@justincormack this messes up ephemeral storage accounting in k8s when there are sparse files