containerd / continuity

A transport-agnostic, filesystem metadata manifest system
https://containerd.io
Apache License 2.0
138 stars 66 forks source link

Support FreeBSD #173

Closed samuelkarp closed 3 years ago

samuelkarp commented 3 years ago

This series of commits adds support for FreeBSD. Aside from TestUsage failing on ZFS (see https://github.com/containerd/continuity/issues/172), all the tests are passing.

Some of the files are pretty awkwardly-named; if you have suggestions for changing them I'm happy to do so.

I recognize that there's no CI coverage for FreeBSD today (though adding at least cross-compiling to CI would be reasonably straightforward) and that there may not be interest in maintaining the code. If that's the case and you prefer not to merge this, I can maintain my own usage of it on my fork.

cpuguy83 commented 3 years ago

I think making sure it compiles is at least important, and maybe a callout in the readme that freebsd support is untested.

samuelkarp commented 3 years ago

@cpuguy83

I think making sure it compiles is at least important

Added to ci.yml

and maybe a callout in the readme that freebsd support is untested.

I took a stab at wording, but I'm happy to change it if there are any other opinions.