search

containerd / continuity

A transport-agnostic, filesystem metadata manifest system
https://containerd.io
Apache License 2.0
138 stars 66 forks source link

Build containerd/continuity on multiple Unix OSes #190

Closed kzys closed 2 years ago

kzys commented 2 years ago

While the .go files have multiple build tags, they haven't been tested on GitHub Actions except for FreeBSD.

This change also fixes #183.

Signed-off-by: Kazuyoshi Kato katokazu@amazon.com

samuelkarp commented 2 years ago

Other than just cross-compiling, have we done any testing on those other operating systems? (In other words: should we include build tags and thus "support" for an operating system that is not tested?)

kzys commented 2 years ago

No. We technically could use GitHub Actions' macOS builder to run VirtualBox (like we do in containerd), but I haven't tried that yet.

I still think this is better than what we have today. We have a bunch of build tags but the combinations are not really tested.

samuelkarp commented 2 years ago

I was going to say that it looks like openbsd and netbsd are new additions and maybe we should let compilation fail, but I see in https://github.com/containerd/continuity/issues/183 that @AkihiroSuda is trying to use continuity on netbsd already.

Looks like there's already a note in the readme about support, so I think this is fine.

kzys commented 2 years ago

@estesp Can you take a look? This should be okay to merge LGTM-wise.