move cmd/continuity to its own go module

containerd / continuity

A transport-agnostic, filesystem metadata manifest system

https://containerd.io

Apache License 2.0

137 stars 66 forks source link

move cmd/continuity to its own go module #200

Closed thaJeztah closed 2 years ago

thaJeztah commented 2 years ago

this command-line is mostly used for testing and debugging, and its dependencies should not be a dependency of the main module (library)

addresses https://github.com/containerd/continuity/issues/199
addresses / supersedes https://github.com/containerd/continuity/pull/194
- for the main module, that is, but we can decide to update the cobra version in the cmd/package in a follow-up

thaJeztah commented 2 years ago

after this, we should consider removing the vendor directory as the main module is then a library

thaJeztah commented 2 years ago

need to tweak some make targets;

+ /home/runner/work/continuity/continuity/src/github.com/containerd/continuity/bin/continuity
main module (github.com/containerd/continuity) does not contain package github.com/containerd/continuity/cmd/continuity
make: *** [/home/runner/work/continuity/continuity/src/github.com/containerd/continuity/bin/continuity] Error 1
Error: Makefile:49: recipe for target '/home/runner/work/continuity/continuity/src/github.com/containerd/continuity/bin/contin

thaJeztah commented 2 years ago

I'll do a rebase (https://github.com/containerd/continuity/pull/198 was merged)

thaJeztah commented 2 years ago

rebased 👍 @kzys @dmcgowan PTAL if this LGTY