search

containerd / continuity

A transport-agnostic, filesystem metadata manifest system
https://containerd.io
Apache License 2.0
141 stars 67 forks source link

Correctly ignore error wrapping `ErrNotSupported` #207

Closed TBBle closed 2 years ago

TBBle commented 2 years ago

Fixes: #206

This change fixes some existing tests which were failing on WIndows:

--- FAIL: TestCopyDirectory (0.03s)
    copy_test.go:45: Copy test failed: failed to build manifest: failed to get resource "\\etc": xattr extraction is not supported: not supported
--- FAIL: TestCopyDirectoryWithLocalSymlink (0.01s)
    copy_test.go:59: Copy test failed: failed to build manifest: failed to get resource "\\link-no-nothing.txt": xattr extraction for symlinks is not supported: not supported
--- FAIL: TestCopyWithLargeFile (9.17s)
    copy_test.go:74: failed to build manifest: failed to get resource "\\banana": xattr extraction is not supported: not supported

The same issue was visible with the command-line tool

> .\continuity.exe build . > ../a.pb
2022/08/11 02:15:44 error generating manifest: failed to get resource "\\.git": xattr extraction is not supported: not supported

now looks like

> .\continuity.exe build . > ../a.pb