search

containerd / continuity

A transport-agnostic, filesystem metadata manifest system
https://containerd.io
Apache License 2.0
139 stars 67 forks source link

devices: use Mkdev, Major and Minor functions from golang.org/x/sys/unix #97

Closed tklauser closed 6 years ago

tklauser commented 6 years ago

Now that golang.org/x/sys/unix provides the Mkdev, Major and Minor functions for every Unix-like OS, use them instead of the locally defined versions.

Suggested by @stevvooe in containerd/containerd#1580.

Fixes #96

Signed-off-by: Tobias Klauser tklauser@distanz.ch

dmcgowan commented 6 years ago

One nit, unless for some non-linux unix systems something different than uint64 is used.

LGTM

stevvooe commented 6 years ago

LGTM

@tklauser Thanks!

tklauser commented 6 years ago

One nit, unless for some non-linux unix systems something different than uint64 is used.

Yes, most of the non-Linux ones use something different than uint64 and the type conversion is needed there.