search

containerd / cri

Moved to https://github.com/containerd/containerd/tree/master/pkg/cri . If you wish to submit issues/PRs, please submit to https://github.com/containerd/containerd
https://github.com/containerd/containerd/tree/master/pkg/cri
Apache License 2.0
900 stars 348 forks source link

Check channel close when receiving events from fsnotify watcher of cni conf dir #1613

Closed abel-von closed 3 years ago

abel-von commented 3 years ago

fix #1612

k8s-ci-robot commented 3 years ago

Hi @abel-von. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fuweid commented 3 years ago

@abel-von The cri repo only receives bugfix for release/1.4 or release/1.3. Could you mind to file pr to https://github.com/containerd/containerd first and then backport ? thanks!

abel-von commented 3 years ago

@abel-von The cri repo only receives bugfix for release/1.4 or release/1.3. Could you mind to file pr to https://github.com/containerd/containerd first and then backport ? thanks!

https://github.com/containerd/containerd/pull/4825

if the PR is accepted, shall I summit the PR to release/1.4 or release 1.3 here?

fuweid commented 3 years ago

@abel-von The cri repo only receives bugfix for release/1.4 or release/1.3. Could you mind to file pr to https://github.com/containerd/containerd first and then backport ? thanks!

containerd/containerd#4825

if the PR is accepted, shall I summit the PR to release/1.4 or release 1.3 here?

Yes! Thanks!