search

containerd / cri

Moved to https://github.com/containerd/containerd/tree/master/pkg/cri . If you wish to submit issues/PRs, please submit to https://github.com/containerd/containerd
https://github.com/containerd/containerd/tree/master/pkg/cri
Apache License 2.0
900 stars 348 forks source link

Fix syntax errors of registry.md #1646

Closed xinfengliu closed 3 years ago

xinfengliu commented 3 years ago

Change plugin to plugins. Otherwise the configuration is ignored silently.

k8s-ci-robot commented 3 years ago

Hi @xinfengliu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mikebrow commented 3 years ago

this repo is closed/archived .. we merged into the containerd/containerd project

mikebrow commented 3 years ago

note.. for service purposes we made the release/1.4 branch the current active branch for this archived repo vs master/main.. if you look at the release/1.4 branch you'll see the commit you made is already there :-) Cheers, Mike