search

containerd / cri

Moved to https://github.com/containerd/containerd/tree/master/pkg/cri . If you wish to submit issues/PRs, please submit to https://github.com/containerd/containerd
https://github.com/containerd/containerd/tree/master/pkg/cri
Apache License 2.0
900 stars 348 forks source link

Add devices for privileged container #1649

Closed scuzhanglei closed 2 years ago

scuzhanglei commented 3 years ago

This is a "cherry-pick" of https://github.com/containerd/containerd/pull/5939 Signed-off-by: zhanglei zhanglei@smartx.com

k8s-ci-robot commented 3 years ago

Hi @scuzhanglei. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qiutongs commented 3 years ago

cc @crosbymichael

qiutongs commented 3 years ago

The build error doesn't seem to be caused by your change.

qiutongs commented 3 years ago

/ok-to-test

k8s-ci-robot commented 3 years ago

@qiutongs: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/containerd/cri/pull/1649#issuecomment-953263345): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
scuzhanglei commented 3 years ago

hi, any update to this?

scuzhanglei commented 3 years ago

ping, thanks

k8s-ci-robot commented 3 years ago

@scuzhanglei: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/containerd/cri/pull/1649#issuecomment-964720272): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
scuzhanglei commented 3 years ago

politely ping

fengye87 commented 3 years ago

The containerd.io package of docker-ce repo is still using 1.4.x versions, so this bug can still affect a lot users. Anything we could help here to make some progress? @qiutongs

scuzhanglei commented 3 years ago

@mikebrow @crosbymichael could you please review this cherry-pick PR or give me some feedback, thanks.

qiutongs commented 2 years ago

Re @fengye87, just pinged in the containerd-dev slack. Hope this can be merged soon.

fuweid commented 2 years ago

/retest

k8s-ci-robot commented 2 years ago

@scuzhanglei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cri-containerd-node-e2e e2e6c47c7bece79d5108bc0b840ef781e8d897db link true /test pull-cri-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
scuzhanglei commented 2 years ago

/retest

k8s-ci-robot commented 2 years ago

@scuzhanglei: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/containerd/cri/pull/1649#issuecomment-986216098): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
scuzhanglei commented 2 years ago

ping

fuweid commented 2 years ago

Sorry for late reply. I checked that release plan about 1.4. It is in extended status which only received security patch.

@scuzhanglei

REF: https://github.com/containerd/containerd/blob/main/RELEASES.md#support-horizon