containerd / fifo

fifo pkg for Go
https://containerd.io
Apache License 2.0
85 stars 30 forks source link

Expose underlying file's `SyscallConn` method. #17

Closed cpuguy83 closed 5 years ago

cpuguy83 commented 5 years ago

This allows raw access to the underlying FD, enabling things like in-kernel copy methods such as splice and tee.

This interface was added to *os.File as part of go1.12beta2.

cpuguy83 commented 5 years ago

ping @tonistiigi

tonistiigi commented 5 years ago

What if the underlying file is not opened yet. Should we return a mock one that unblocks when the opened channel closes?

cpuguy83 commented 5 years ago

Ah just realized there is the non-blocking open.

cpuguy83 commented 5 years ago

Updated, added new tests, updated CI to test on tip so that new tests will actually run.

cpuguy83 commented 5 years ago

From travis run 😄

image