search

containerd / fifo

fifo pkg for Go
https://containerd.io
Apache License 2.0
87 stars 30 forks source link

fails to compile on arm64 (syscall.Dup2 not available) #27

Closed BenTheElder closed 4 years ago

BenTheElder commented 4 years ago

syscall.Dup2 is not available on arm64, this breaks building containerd on arm64 after https://github.com/containerd/containerd/pull/4657

It looks like https://github.com/golang/sys/commit/9d4e42a20653790449273b3c85e67d6d8bae6e2e has a wrapper in golang.org/x/sys/unix.Dup2

https://golang.org/pkg/syscall/ says:

Deprecated: this package is locked down. Callers should use the corresponding package in the golang.org/x/sys repository instead. That is also where updates required by new systems or versions should be applied. See https://golang.org/s/go1.4-syscall for more information.

So I think we should probably just switch the package out.