containerd / fifo

fifo pkg for Go

https://containerd.io

Apache License 2.0

87 stars 30 forks source link

Fix linting, remove solaris code, and exclude files on Windows #39

Closed thaJeztah closed 3 years ago

thaJeztah commented 3 years ago

This reverts https://github.com/containerd/fifo/commit/14d831365bf0512ec3d3eaaedff4b63fac1edf73 (https://github.com/containerd/fifo/pull/36), as there were many other paths that failed to compile on Windows, so it was a wasted effort.

Also;

removes the solaris code, which caused additional failures and is unmaintained/unused
excludes all files on windows
fixes some gofmt and linting failures on the non-linux files

~Unfortunately, linting still fails on windows; see https://github.com/containerd/fifo/pull/38#issuecomment-807125971 for unknown reasons, so I think I'll call it a day (no windows code should import this)~

thaJeztah commented 3 years ago

Tested these changes in https://github.com/containerd/containerd/pull/5269 to verify all is working

thaJeztah commented 3 years ago

38 is now green with these changes; thanks to @mxpv for pointing me to the "newlines" issue on Windows linters