search

containerd / go-cni

A generic CNI library to provide APIs for CNI plugin interactions
Apache License 2.0
146 stars 56 forks source link

Implement STATUS #121

Open architkulkarni opened 2 weeks ago

architkulkarni commented 2 weeks ago

Based on @MikeZappa87's earlier PR https://github.com/containerd/go-cni/pull/114.

This commit implements the STATUS CNI verb. It adds a new function StatusDetail to return the result of STATUS for each network.

Related info:

architkulkarni commented 1 week ago

I don't understand the linter errors that appeared after the last two commits, they seem unrelated. Any ideas?

mikebrow commented 6 days ago

I don't understand the linter errors that appeared after the last two commits, they seem unrelated. Any ideas?

Dunno.. the last commit success build here was in june.. you could try an empty commit (1line doc change) and see if our current version of stretcher 1.8.0 , golang, lint all still work .. noting that the core repo has moved up with stretcher 1.9 now the latest

architkulkarni commented 6 days ago

A bit weird because it passed two commits ago on this PR last week: https://github.com/containerd/go-cni/actions/runs/11351584389/job/31572471088 But let me try what you suggested

mikebrow commented 6 days ago

A bit weird because it passed two commits ago on this PR last week: https://github.com/containerd/go-cni/actions/runs/11351584389/job/31572471088 But let me try what you suggested

ikr.. sure enough though even trivial non code no longer passes

mikebrow commented 6 days ago

let's see on the working run you linked for the linter 1.21.8 test we have: setup go v3 action results in go version 1.21.13 looks good odd regarding the matrix though having the wrong version 1.21.8 vs 1.21.13 lint v3 action gives v1.56.1

on the failure here for the same 1.21.8 bucket we have setup go v1.23.2 uhmm... and lint v1.56.1 wonder if that combo is expected to work?