search

containerd / go-cni

A generic CNI library to provide APIs for CNI plugin interactions
Apache License 2.0
146 stars 56 forks source link

Fix Loopback Version #88

Closed MikeZappa87 closed 2 years ago

MikeZappa87 commented 2 years ago

We missed this when adding the CHECK code to go-cni. @mikebrow and I have been talking about how we can move forward with this. We decided to update the version and come up with a plan to possibly remove this with the goal to be explicitly added. This is also a conversation the CNI maintainers have had as well! More to come!

codecov-commenter commented 2 years ago

Codecov Report

Merging #88 (8e931cf) into main (e559bd8) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   44.41%   44.41%           
=======================================
  Files           9        9           
  Lines         403      403           
=======================================
  Hits          179      179           
  Misses        190      190           
  Partials       34       34
Impacted Files Coverage Δ
opts.go 15.21% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e559bd8...8e931cf. Read the comment docs.

dmcgowan commented 2 years ago

Please squash the commits and make sure the commit is signed