Portability and type improvements for unix socket handling

justincormack commented 7 years ago

Pdeathsig only exists on Linux; make this conditional
add our own recvFd implementation, as the runc one is included in github.com/opencontainers/runc/libcontainer/utils which is Linux specific; this implementation is a little cleanup up to use Go unix socket specific functions rather than the syscalls from s/sys/unix where possible. This removes a whole chunk of runc dependencies from containerd
while in the cleaning up unix socket mood, clean up net.Listener to be the more specific net.UnixListener; this means we do not have to store path as it is available as the local address of a listener.

With these changes and some more fixes in containerd I have containerd-shim compiling on Darwin.

Tested with containerd master.

crosbymichael commented 7 years ago

LGTM

dqminh commented 7 years ago

LGTM

containerd / go-runc