No reason to require cgo build

containerd / go-runc

runc bindings for Go

Apache License 2.0

161 stars 71 forks source link

No reason to require cgo build #16

Closed justincormack closed 7 years ago

justincormack commented 7 years ago

This just uses unix sockets, does not require cgo

Signed-off-by: Justin Cormack justin.cormack@docker.com

I can't see any reason why this is needed... this helps cross compile support which doesn't work with cgo see https://github.com/containerd/containerd/issues/866

justincormack commented 7 years ago

Previously it used net.Listen not net.ResolveUnixAddr and net.ListenUnix which was probably the reason why it used cgo at a guess; this was removed in #12 though.

crosbymichael commented 7 years ago

It had the tag because it depended on the console package that used cgo

dqminh commented 7 years ago

@justincormack maybe because containerd/console requires cgo ?

justincormack commented 7 years ago

Well I also just opened a PR to remove that https://github.com/containerd/console/pull/9

dqminh commented 7 years ago

LGTM.

I also have a console related change that im still need to find some time soon to test https://github.com/opencontainers/runc/pull/1455/files and move to containerd/console maybe. But thats linux only and also should not depend on cgo

crosbymichael commented 7 years ago

LGTM