containerd / go-runc

runc bindings for Go
Apache License 2.0
162 stars 73 forks source link

add ffjson for faster json decoding #34

Closed crosbymichael closed 6 years ago

crosbymichael commented 6 years ago

This helps reduce cpu usage when decoding json from runc.

Signed-off-by: Michael Crosby crosbymichael@gmail.com

estesp commented 6 years ago

this looks really valuable. Should there be some form of script or README addition that shows how they were generated in case it needs to be updated in the future and you aren't around? :)

crosbymichael commented 6 years ago

@estesp but i will last forever, I don't understand your concerns.

jk, good idea

crosbymichael commented 6 years ago

@estesp updated

dqminh commented 6 years ago

I think there's also https://github.com/json-iterator/go which doesnt require code-gen and is also really fast

crosbymichael commented 6 years ago

@dqminh nice. i think that will be better because we can use it for spec marshal and unmarshal as well.