search

containerd / go-runc

runc bindings for Go
Apache License 2.0
161 stars 71 forks source link

Use user-specific temp directory if set #41

Closed Callisto13 closed 6 years ago

Callisto13 commented 6 years ago

This allows non-privileged users to use containerd. This is part of a larger track of work integrating containerd into Cloudfoundry's garden with support for rootless.

This is linked to https://github.com/containerd/containerd/pull/2325

[#156343575]

Signed-off-by: Claudia Beresford cberesford@pivotal.io

Callisto13 commented 6 years ago

@crosbymichael bump just incase github didn't update you on the force push :)

crosbymichael commented 6 years ago

@Callisto13 do you know if there is a distinction between the stickybit being on the directory or the files inside for auto prune?

BooleanCat commented 6 years ago

@crosbymichael @Callisto13 The XDG Base Directory Specification is ambiguous on this topic, it's unclear (at least to me) whether the spec describes files as any file or as non-directories.

Although, it appears that systemd creates sockets in subdirectories of XDG_RUNTIME_DIR and doesn't set the sticky bit on those files.

crosbymichael commented 6 years ago

LGTM

Thanks for looking into this more @BooleanCat