Break apart NewPipeIO to windows/unix

containerd / go-runc

runc bindings for Go

Apache License 2.0

161 stars 71 forks source link

Break apart NewPipeIO to windows/unix #45

Closed jterry75 closed 5 years ago

jterry75 commented 5 years ago

Moves NewPipeIO to GOOS specific to avoid setting the unix.Fchown flags that dont apply on windows.

Signed-off-by: Justin Terry (VM) juterry@microsoft.com

crosbymichael commented 5 years ago

Which part of this pkg were you needing to depend on? Just the I/O part?

jterry75 commented 5 years ago

@crosbymichael - I decided to make the equivalent go-runhcs for a few reasons and rather than re-inventing the wheel I am trying to simply reuse the go-runc: Monitor, IO portions since they are already well written to be platform agnostic. This is a super early commit in my testing/impl but take a look at: Microsoft/hcsshim:go_runhcs. Then I can make the shim actually use this package and avoid all command logic in the shim at all.

crosbymichael commented 5 years ago

LGTM