search

containerd / go-runc

runc bindings for Go
Apache License 2.0
161 stars 71 forks source link

avoid setting NOTIFY_SOCKET from calling process #54

Closed tonistiigi closed 4 years ago

tonistiigi commented 4 years ago

Having NOTIFY_SOCKET set mutates the spec in runc in unexpected way. As this feature is for running runc with systemd it doesn't have use for go-runc.

related to https://github.com/moby/moby/issues/39866

@crosbymichael

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

crosbymichael commented 4 years ago

Can you rebase on master to pick up the fix for travis plz?

codecov-io commented 4 years ago

Codecov Report

Merging #54 into master will decrease coverage by 0.08%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #54      +/-   ##
=========================================
- Coverage    6.12%   6.03%   -0.09%     
=========================================
  Files           7       7              
  Lines         637     646       +9     
=========================================
  Hits           39      39              
- Misses        591     600       +9     
  Partials        7       7
Impacted Files Coverage Δ
command_linux.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4bc25a...c0c55f3. Read the comment docs.

crosbymichael commented 4 years ago

LGTM

AkihiroSuda commented 4 years ago

Can we rather fix the issue on runc side?

tonistiigi commented 4 years ago

Can we rather fix the issue on runc side?

I would be for it but we do need something for a patch release as well and as this affects tools like buildkit and containerd it isn't always very easy to control what runc binary they use.