containerd / go-runc

runc bindings for Go
Apache License 2.0
161 stars 71 forks source link

Parse runc version even if commit is missing #60

Closed twz123 closed 4 years ago

twz123 commented 4 years ago

This is the case for the binaries distributed on GitHub.

codecov-io commented 4 years ago

Codecov Report

Merging #60 into master will decrease coverage by 1.16%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   13.43%   12.26%   -1.17%     
==========================================
  Files           7        7              
  Lines         655      644      -11     
==========================================
- Hits           88       79       -9     
+ Misses        544      543       -1     
+ Partials       23       22       -1
Impacted Files Coverage Δ
runc.go 7.04% <100%> (-2.25%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8aa1fd6...9e92203. Read the comment docs.

twz123 commented 4 years ago

@Zyqsempai already done in 9e92203 ;)