containerd / go-runc

runc bindings for Go
Apache License 2.0
161 stars 71 forks source link

Change the type of PdeathSignal #61

Closed KentaTada closed 4 years ago

KentaTada commented 4 years ago

As related to https://github.com/containerd/containerd/pull/4317, this commit changes the definition of PdeathSignal to use x/sys.

Signed-off-by: Kenta Tada Kenta.Tada@sony.com

codecov-commenter commented 4 years ago

Codecov Report

Merging #61 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   12.26%   12.26%           
=======================================
  Files           7        7           
  Lines         644      644           
=======================================
  Hits           79       79           
  Misses        543      543           
  Partials       22       22           
Impacted Files Coverage Δ
runc.go 7.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7016d3c...421b4ca. Read the comment docs.

crosbymichael commented 4 years ago

LGTM

thehajime commented 3 years ago

I filed an issue (https://github.com/containerd/go-runc/issues/65): please take a look at it.