search

containerd / go-runc

runc bindings for Go
Apache License 2.0
161 stars 71 forks source link

preserve exit status with wrapped errors #68

Closed coryb closed 3 years ago

coryb commented 3 years ago

We need to be able capture the exit status from Exec, currently the status is discarded. This PR uses wrapped error to preserve the status via an ExitError.

I have also removed the Go 1.12.x travis testing, since errors.As used in the test was introduced in 1.13.

cc @tonistiigi

codecov-io commented 3 years ago

Codecov Report

Merging #68 into master will increase coverage by 8.44%. The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   10.72%   19.17%   +8.44%     
==========================================
  Files           7        7              
  Lines         578      579       +1     
==========================================
+ Hits           62      111      +49     
+ Misses        494      432      -62     
- Partials       22       36      +14
Impacted Files Coverage Δ
runc.go 18.18% <62.50%> (+12.10%) :arrow_up:
io.go 5.97% <0.00%> (+5.97%) :arrow_up:
monitor.go 88.88% <0.00%> (+27.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7c5957f...78b8bdd. Read the comment docs.