Fix runc update --resources flag usage

containerd / go-runc

runc bindings for Go

Apache License 2.0

161 stars 71 forks source link

Closed brandond closed 3 years ago

brandond commented 3 years ago

Runc's CLI requires --flag=value arg passing. Xref: https://github.com/k3s-io/k3s/issues/3104

Signed-off-by: Brad Davidson brad.davidson@rancher.com

brandond commented 3 years ago

cc @AkihiroSuda

AkihiroSuda commented 3 years ago

Runc's CLI requires --flag=value arg passing.

This is because k3s variant of runc use urfave cli v1.22 https://github.com/urfave/cli/issues/1092

So if you downgrade urfave cli to v1.21 (used by upstream runc) you will no longer see the error.

Anyway, this PR is harmless to upstream runc and LGTM