search

containerd / go-runc

runc bindings for Go
Apache License 2.0
162 stars 73 forks source link

Reduce Windows stubs #79

Closed thaJeztah closed 3 years ago

thaJeztah commented 3 years ago

Commit 421b4cab7d101dabcb4a1ff6348ce9b695431b0b (https://github.com/containerd/go-runc/pull/61) changed the use of syscall.Signal in favor of unix.Signal, to match other code.

As a result, some code that imported these files on Windows (even if unused) failed to compile, which lead to d6ba49689be98a4278ce479200f72e1f25404dc4 (https://github.com/containerd/go-runc/pull/66), which created a separate implementation for Windows without PdeathSignal.

Given that golang.org/x/sys/unix.Signal is an alias for syscall.Signal (see https://github.com/golang/sys/blob/751e447fb3d0a97f584890476adddc1d56307388/unix/aliases.go#L13-L14), they should be interchangeable.

Note that the io.go files could probably be excluded on Windows as a whole, but taking a slightly less rigorous approach in this PR.

codecov-commenter commented 3 years ago

Codecov Report

Merging #79 (cb9c869) into main (d1e3ca2) will decrease coverage by 0.06%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   21.52%   21.45%   -0.07%     
==========================================
  Files           7        7              
  Lines         683      685       +2     
==========================================
  Hits          147      147              
- Misses        498      500       +2     
  Partials       38       38
Impacted Files Coverage Δ
io.go 6.45% <0.00%> (-0.15%) :arrow_down:
io_unix.go 0.00% <0.00%> (ø)
runc.go 21.07% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1e3ca2...cb9c869. Read the comment docs.