search

containerd / go-runc

runc bindings for Go
Apache License 2.0
161 stars 71 forks source link

Lock to OS thread when Pdeathsig is set #86

Closed aaronlehmann closed 1 year ago

aaronlehmann commented 1 year ago

See https://github.com/golang/go/issues/27505 for context. Pdeathsig isn't safe to set without locking to the current OS thread, because otherwise thread termination will send the signal, which isn't the desired behavior.

I discovered this while troubleshooting a problem that turned out to be unrelated, but I think it's necessary for correctness.

cc @coryb

codecov-commenter commented 1 year ago

Codecov Report

Base: 21.52% // Head: 20.27% // Decreases project coverage by -1.25% :warning:

Coverage data is based on head (51f9c48) compared to base (2e979ca). Patch coverage: 10.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #86 +/- ## ========================================== - Coverage 21.52% 20.27% -1.26% ========================================== Files 7 7 Lines 683 735 +52 ========================================== + Hits 147 149 +2 - Misses 499 545 +46 - Partials 37 41 +4 ``` | [Impacted Files](https://codecov.io/gh/containerd/go-runc/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [monitor.go](https://codecov.io/gh/containerd/go-runc/pull/86/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-bW9uaXRvci5nbw==) | `40.90% <0.00%> (-49.10%)` | :arrow_down: | | [runc.go](https://codecov.io/gh/containerd/go-runc/pull/86/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cnVuYy5nbw==) | `20.24% <16.66%> (-0.95%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

aaronlehmann commented 1 year ago

This has been open for quite awhile. Is there anyone specific I can ping to review it?

aaronlehmann commented 1 year ago

Not in a huge rush for this one, but would just like to get it merged so we can close the book on it. Is there anything else you need from me to push it forward?