containerd / go-runc

runc bindings for Go
Apache License 2.0
162 stars 73 forks source link

Fix Run api with ExtraFiles in CreateOpts #95

Closed sfc-gh-bxin closed 1 year ago

sfc-gh-bxin commented 1 year ago

Pass along CreateOpts.ExtraFiles in the Run(..) API.

Create(..) API already handles this correctly.

Signed-off-by: Bin Xin bin.xin@snowflake.com

codecov-commenter commented 1 year ago

Codecov Report

Base: 20.95% // Head: 21.06% // Increases project coverage by +0.11% :tada:

Coverage data is based on head (f4e1730) compared to base (42adae7). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #95 +/- ## ========================================== + Coverage 20.95% 21.06% +0.11% ========================================== Files 7 7 Lines 711 712 +1 ========================================== + Hits 149 150 +1 Misses 524 524 Partials 38 38 ``` | [Impacted Files](https://codecov.io/gh/containerd/go-runc/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [runc.go](https://codecov.io/gh/containerd/go-runc/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cnVuYy5nbw==) | `21.68% <100.00%> (+0.20%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.